Messages in this thread | | | Date | Thu, 5 Jun 2014 03:12:42 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 4/6] scsi_error: fix invalid setting of host byte |
| |
On Wed, Jun 04, 2014 at 01:34:57PM +0200, Paolo Bonzini wrote: > From: Ulrich Obergfell <uobergfe@redhat.com> > > After scsi_try_to_abort_cmd returns, the eh_abort_handler may have > already found that the command has completed in the device, causing > the host_byte to be nonzero (e.g. it could be DID_ABORT). When > this happens, ORing DID_TIME_OUT into the host byte will corrupt > the result field and initiate an unwanted command retry. > > Fix this by using set_host_byte instead, following the model of > commit 2082ebc45af9c9c648383b8cde0dc1948eadbf31. > > Cc: stable@vger.kernel.org > Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com> > [Fix all instances according to review comments. - Paolo] > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |