lkml.org 
[lkml]   [2014]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call
    Date
    Added a guaranteed null-terminate after call to strncpy.

    This was partly found using a static code analysis program called cppcheck.

    Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
    ---
    drivers/staging/usbip/stub_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
    index 9c5832a..f1eb6a2 100644
    --- a/drivers/staging/usbip/stub_main.c
    +++ b/drivers/staging/usbip/stub_main.c
    @@ -166,6 +166,7 @@ static ssize_t store_match_busid(struct device_driver *dev, const char *buf,
    return -EINVAL;

    strncpy(busid, buf + 4, BUSID_SIZE);
    + busid[BUSID_SIZE - 1] = '\0';

    if (!strncmp(buf, "add ", 4)) {
    if (add_match_busid(busid) < 0)
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2014-06-05 00:21    [W:3.449 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site