Messages in this thread | | | Date | Wed, 4 Jun 2014 13:42:21 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins |
| |
On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote: > On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote: > > +void traceevent_plugin_free_options_list(char **list) > > +{ > > + int i; > > + > > + if (!list) > > + return; > > + > > + if (list == (char **)((unsigned long)-1)) > > It also should be: > > if (list == INVALID_PLUGIN_LIST_OPTION) > > > Other than that, the series looks good to me now!
can I use your Acked-by?
thanks, jirka
| |