lkml.org 
[lkml]   [2014]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] tools lib traceevent: Add options to plugins
On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote:
> On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote:
> > +void traceevent_plugin_free_options_list(char **list)
> > +{
> > + int i;
> > +
> > + if (!list)
> > + return;
> > +
> > + if (list == (char **)((unsigned long)-1))
>
> It also should be:
>
> if (list == INVALID_PLUGIN_LIST_OPTION)
>
>
> Other than that, the series looks good to me now!

can I use your Acked-by?

thanks,
jirka


\
 
 \ /
  Last update: 2014-06-04 14:41    [W:0.458 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site