Messages in this thread | | | Date | Mon, 30 Jun 2014 21:59:17 -0400 | Subject | Re: [PATCH] Fixes gemmi_idle in file idle.c | From | Nick Krause <> |
| |
Thanks for the good feedback on kernel development , I will delete this file in order to clean up race conditions caused by it. Cheers Nick
On Mon, Jun 30, 2014 at 5:41 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Sun, Jun 29, 2014 at 10:52:40PM -0400, Nicholas Krause wrote: >> disables the IRQ line in gemmi_idle before calling cpu_do_idle. >> In addition, according to the Fixme message in this file fixes >> races that may occur due to not disabling the IRQ before calling >> cpu_do_idle. > > 1) the idle method is called with interrupts already disabled. > 2) I wonder if you read the comment above the comment you removed, and > if so, why it wasn't removed. > 3) can you indicate how the hardware problem has been fixed, or give some > justification why this change should be accepted. > > -- > FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly > improving, and getting towards what was expected from it.
| |