Messages in this thread | | | Date | Mon, 30 Jun 2014 14:01:17 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 4/4] tracing/uprobes: Fix the usage of uprobe_buffer_enable() in probe_event_enable() |
| |
On Mon, 30 Jun 2014 19:50:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> Well, I do not really mind. But to me it looks more consistent this way, > if-something-fail-goto-err_label. > > IOW, I think that the code should either not use err-labels, or always > use them like above.
Ah I missed the other error labels. Yeah, we should keep the patch as is to be consistent (also it means I don't need to restart a test that's already been running for hours).
-- Steve
> > Besides, perhaps we will add "if (file) uprobe_apply()" after _register() > to mix perf/ftrace, then we will need to change this "if (!ret)" code again. > > Oleg.
| |