Messages in this thread | | | From | Bandan Das <> | Subject | Re: [PATCH] KVM: x86: Fix lapic.c debug prints | Date | Mon, 30 Jun 2014 13:39:48 -0400 |
| |
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 30/06/2014 03:03, Nadav Amit ha scritto: >>>> >>>> sipi_vector = apic->sipi_vector; >>>> - pr_debug("vcpu %d received sipi with vector # %x\n", >>>> + apic_debug("vcpu %d received sipi with vector # %x\n", >>> >>> Why don't we just use pr_debug all throughout ? >>> >> I don't know. I just tried to make it consistent, since it really bugged >> me while I was debugging the local-apic. >> If you prefer the other way around (which does seem to be better), I can >> do the search-and-replace. > > vcpu number probably could be moved inside apic_debug, at which point > apic_debug becomes preferrable.
I am not sure, I think all that could be achieved with a file private debug define can be done with pr_debug which is generic. Nadav didn't introduce apic_debug to this file, so I am fine either way.
> Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |