Messages in this thread Patch in this message | | | Date | Mon, 30 Jun 2014 21:52:27 +0530 | Subject | Re: [PATCHv7 0/5] Common Mailbox Framework | From | Jassi Brar <> |
| |
On 30 June 2014 21:46, Lubomir Rintel <lkundrak@v3.sk> wrote: > Hi Jassi, > > On Thu, 2014-06-12 at 22:28 +0530, Jassi Brar wrote: >> Hello, >> Here is the next revision of Mailbox framwork. > > I'm wondering whether you keep a Git tree with the framework we could > keep the Raspberry Pi mailbox driver based on (bcm2835-mbox)? > > Also, from look at the API it does not seem to me that it's possible to > synchronously (that is without a tx_done callback) collect a response > when a message is sent with tx_block enabled. Equivalent to this: [1] > Thanks, good catch.
Could you please give this a try...
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index afa63cd..4059602 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -101,10 +101,11 @@ static void tx_tick(struct mbox_chan *chan, int r) _msg_submit(chan);
/* Notify the client */ + if (mssg && chan->cl->tx_done) + chan->cl->tx_done(chan->cl, mssg, r); + if (chan->cl->tx_block) complete(&chan->tx_complete); - else if (mssg && chan->cl->tx_done) - chan->cl->tx_done(chan->cl, mssg, r); }
static void poll_txdone(unsigned long data) -jassi
| |