lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 073/181] lz4: ensure length does not wrap
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 206204a1162b995e2185275167b22468c00d6b36 upstream.

    Given some pathologically compressed data, lz4 could possibly decide to
    wrap a few internal variables, causing unknown things to happen. Catch
    this before the wrapping happens and abort the decompression.

    Reported-by: "Don A. Bailey" <donb@securitymouse.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    lib/lz4/lz4_decompress.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c
    index df6839e3ce08..99a03acb7d47 100644
    --- a/lib/lz4/lz4_decompress.c
    +++ b/lib/lz4/lz4_decompress.c
    @@ -72,6 +72,8 @@ static int lz4_uncompress(const char *source, char *dest, int osize)
    len = *ip++;
    for (; len == 255; length += 255)
    len = *ip++;
    + if (unlikely(length > (size_t)(length + len)))
    + goto _output_error;
    length += len;
    }

    --
    2.0.0


    \
     
     \ /
      Last update: 2014-06-30 15:21    [W:3.412 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site