Messages in this thread | | | Date | Tue, 3 Jun 2014 17:35:05 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 11/13] perf tests: Allow reuse of test_file function |
| |
On Tue, Jun 03, 2014 at 07:51:31AM -0600, David Ahern wrote: > On 6/2/14, 3:18 PM, Jiri Olsa wrote: > >Making the test_file function to be reusable for > >new tests coming in following patches. > > > >Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > >Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > >Cc: David Ahern <dsahern@gmail.com> > >Cc: Frederic Weisbecker <fweisbec@gmail.com> > >Cc: Ingo Molnar <mingo@kernel.org> > >Cc: Jean Pihet <jean.pihet@linaro.org> > >Cc: Namhyung Kim <namhyung@kernel.org> > >Cc: Paul Mackerras <paulus@samba.org> > >Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > >Signed-off-by: Jiri Olsa <jolsa@kernel.org> > >--- > > tools/perf/tests/dso-data.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > >diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c > >index 3e6cb17..f5c8743 100644 > >--- a/tools/perf/tests/dso-data.c > >+++ b/tools/perf/tests/dso-data.c > >@@ -12,11 +12,15 @@ > > > > static char *test_file(int size) > > { > >- static char buf_templ[] = "/tmp/test-XXXXXX"; > >+#define TEMPL "/tmp/test-XXXXXX" > > use /tmp/perf-test-XXXXXX or /tmp/perf-XXXXXX to we know where all > these tmp files came from.
ok
> > >+ static char buf_templ[sizeof(TEMPL)]; > > why static? and ...
I need to use it outside the test_file function
> > > char *templ = buf_templ; > > int fd, i; > > unsigned char *buf; > > > >+ strcpy(buf_templ, TEMPL); > >+#undef TEMPL > > why the need to change from char buf_templ[] to strcpy?
because it gets overwritten via mkstemp function
thanks, jirka
| |