lkml.org 
[lkml]   [2014]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before kfree
Date


> -----Original Message-----
> From: iommu-bounces@lists.linux-foundation.org [mailto:iommu-
> bounces@lists.linux-foundation.org] On Behalf Of Fabian Frederick
> Sent: Sunday, June 29, 2014 1:31 PM
> To: linux-kernel@vger.kernel.org
> Cc: Fabian Frederick; Grant Likely; iommu@lists.linux-foundation.org;
> devicetree@vger.kernel.org
> Subject: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before
> kfree
>
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: iommu@lists.linux-foundation.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/iommu/fsl_pamu_domain.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/fsl_pamu_domain.c
> b/drivers/iommu/fsl_pamu_domain.c index 93072ba..0009dff 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -1118,8 +1118,7 @@ static int fsl_pamu_set_windows(struct iommu_domain
> *domain, u32 w_count)
> ret = pamu_set_domain_geometry(dma_domain, &domain->geometry,
> ((w_count > 1) ? w_count : 0));
> if (!ret) {
> - if (dma_domain->win_arr)
> - kfree(dma_domain->win_arr);
> + kfree(dma_domain->win_arr);
> dma_domain->win_arr = kzalloc(sizeof(struct dma_window) *
> w_count, GFP_ATOMIC);
> if (!dma_domain->win_arr) {

Acked-by: Varun Sethi <varun.sethi@freescale.com>


\
 
 \ /
  Last update: 2014-06-29 13:41    [W:0.049 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site