lkml.org 
[lkml]   [2014]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks
Hello Yadwinder,

Thanks a lot for your feedback.

On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote:
> Hi Javier,
>
> Sorry for jumping in late, but just one concern mentioned inline.
>
> [ .. ]
>
>> +
>> +static unsigned long max_gen_recalc_rate(struct clk_hw *hw,
>> + unsigned long parent_rate)
>> +{
>> + return 32768;
>> +}
>
> Isn't more safer(correct), if it check and return 0 when clk is
> disabled(unprepared) ?
>

Makes sense to me. I'll add a if (__clk_is_enabled(hw->clk)) check in the next
version.

> Regards,
> Yadwinder
>

Best regards,
Javier


\
 
 \ /
  Last update: 2014-06-26 15:01    [W:0.036 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site