Messages in this thread | | | Date | Thu, 26 Jun 2014 14:31:36 +0200 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks |
| |
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote: > Hi Javier, > > Sorry for jumping in late, but just one concern mentioned inline. > > [ .. ] > >> + >> +static unsigned long max_gen_recalc_rate(struct clk_hw *hw, >> + unsigned long parent_rate) >> +{ >> + return 32768; >> +} > > Isn't more safer(correct), if it check and return 0 when clk is > disabled(unprepared) ? >
Makes sense to me. I'll add a if (__clk_is_enabled(hw->clk)) check in the next version.
> Regards, > Yadwinder >
Best regards, Javier
| |