Messages in this thread | | | Date | Tue, 24 Jun 2014 18:20:29 +0900 | From | AKASHI Takahiro <> | Subject | Re: [PATCH] arm: ptrace: fix syscall modification under PTRACE_O_TRACESECCOMP |
| |
On 06/24/2014 05:54 PM, Will Deacon wrote: > On Mon, Jun 23, 2014 at 08:46:52PM +0100, Kees Cook wrote: >> On Mon, Jun 23, 2014 at 1:46 AM, Will Deacon <will.deacon@arm.com> wrote: >>> On Fri, Jun 20, 2014 at 07:10:46PM +0100, Kees Cook wrote: >>>> On Fri, Jun 20, 2014 at 10:36 AM, Kees Cook <keescook@chromium.org> wrote: >>>>> On Fri, Jun 20, 2014 at 10:23 AM, Will Deacon <will.deacon@arm.com> wrote: >>>>>> Right, gotcha. Thanks for the explanation. I was confused, because >>>>>> tracehook_report_syscall does the right thing (returns >>>>>> current_thread_info()->syscall), but if we don't have TIF_SYSCALL_TRACE set, >>>>>> then updates during the secure_computing callback will be ignored. >>>>>> >>>>>> However, my fix to this is significantly smaller than your patch, so I fear >>>>>> I'm still missing something. >>>>> >>>>> Oh, yes, that's much smaller. Nice! I will test this and report back. >>>> >>>> Yup, I can confirm this works. Thanks! >>>> >>>> Tested-by: Kees Cook <keescook@chromium.org> >>> >>> Thanks, Kees. I'll post a patch shortly. I'll try and remember to keep an >>> eye out for this when seccomp lands for arm64 too. >> >> Great, thanks! >> >> What's the state of seccomp on arm64? I saw a series back in March, >> but nothing since then? It looked complete, but I haven't set up a >> test environment yet to verify. > > I think Akashi was going to repost `real soon now' so we can include them > for 3.17. He missed the merge window last time around.
Do I really have to repost my patch even without any changes since the last one? Just kidding. I will do so once I confirm the issue discussed here. (I've finally found out a user of my patch :)
-Takahiro AKASHI
> Will > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
| |