Messages in this thread | | | Date | Mon, 2 Jun 2014 22:19:47 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] tools: lib: traceevent: parse-filter.c: Cleaning up memory leak |
| |
On Sun, 1 Jun 2014 13:36:56 +0200 Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote:
> There is a risk for memory leak in when something unexpected happens > and the function returns. > > This was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> --- > tools/lib/traceevent/parse-filter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c > index b502344..5865c9e 100644 > --- a/tools/lib/traceevent/parse-filter.c > +++ b/tools/lib/traceevent/parse-filter.c > @@ -1492,8 +1492,10 @@ static int copy_filter_type(struct event_filter *filter, > arg->boolean.value = 0; > > filter_type = add_filter_type(filter, event->id); > - if (filter_type == NULL) > + if (filter_type == NULL) { > + free_arg(arg); > return -1; > + } > > filter_type->filter = arg; >
| |