lkml.org 
[lkml]   [2014]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 3.15 regression: wrong cgroup magic
On Tue, Jun 03, 2014 at 09:18:25AM +0800, Li Zefan wrote:
> > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312
> > Author: Tejun Heo <tj@kernel.org>
> > Date: Tue Feb 11 11:52:49 2014 -0500
> >
> > cgroup: convert to kernfs
> >
> > In particular, this piece:
> >
> > - sb->s_magic = CGROUP_SUPER_MAGIC;
> >
> > The result is that cgroup shows up with the wrong magic number, so my
> > code goes "oh crap, cgroupfs isn't mounted" and fails.
> >
> > I can change my code to hack around this, but I can imagine other
> > things getting tripped up. Is there still time to fix this?
> >
>
> This should be fixed by "kernfs: move the last knowledge of sysfs out from kernfs".
>
> It's in driver-core-next.
>
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=26fc9cd200ec839e0b3095e05ae018f27314e7aa

Right, I was writing about the same patch with a nagging sense of
deja-vu. I should have noticed that this must go through
driver-core-linus not -next. Sorry about that.

Linus, can you please cherry-pick the commit?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-06-03 04:41    [W:0.092 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site