Messages in this thread | | | Date | Mon, 2 Jun 2014 18:35:02 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH -mm] slab: delete cache from list after __kmem_cache_shutdown succeeds |
| |
On Thu, 15 May 2014, Vladimir Davydov wrote:
> Currently, on kmem_cache_destroy we delete the cache from the slab_list > before __kmem_cache_shutdown, inserting it back to the list on failure. > Initially, this was done, because we could release the slab_mutex in > __kmem_cache_shutdown to delete sysfs slub entry, but since commit > 41a212859a4d ("slub: use sysfs'es release mechanism for kmem_cache") we > remove sysfs entry later in kmem_cache_destroy after dropping the > slab_mutex, so that no implementation of __kmem_cache_shutdown can ever > release the lock. Therefore we can simplify the code a bit by moving > list_del after __kmem_cache_shutdown. > > Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Acked-by: David Rientjes <rientjes@google.com>
| |