Messages in this thread | | | Date | Mon, 2 Jun 2014 15:44:31 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/3] memory-failure: Send right signal code to correct thread |
| |
On Fri, 30 May 2014 02:51:08 -0400 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> From: Tony Luck <tony.luck@intel.com> > > When a thread in a multi-threaded application hits a machine > check because of an uncorrectable error in memory - we want to > send the SIGBUS with si.si_code = BUS_MCEERR_AR to that thread. > Currently we fail to do that if the active thread is not the > primary thread in the process. collect_procs() just finds primary > threads and this test: > if ((flags & MF_ACTION_REQUIRED) && t == current) { > will see that the thread we found isn't the current thread > and so send a si.si_code = BUS_MCEERR_AO to the primary > (and nothing to the active thread at this time). > > We can fix this by checking whether "current" shares the same > mm with the process that collect_procs() said owned the page. > If so, we send the SIGBUS to current (with code BUS_MCEERR_AR). > > Reported-by: Otto Bruggeman <otto.g.bruggeman@intel.com> > Signed-off-by: Tony Luck <tony.luck@intel.com> > Cc: Andi Kleen <andi@firstfloor.org> > Cc: Borislav Petkov <bp@suse.de> > Cc: Chen Gong <gong.chen@linux.jf.intel.com> > Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
You were on the patch delivery path, so it should have included your signed-off-by. Documentation/SubmittingPatches section 12 has the details.
I have made that change to my copies of patches 1 and 2.
| |