Messages in this thread | | | From | Reyad Attiyat <> | Date | Mon, 2 Jun 2014 14:54:40 -0500 | Subject | Re: [PATCH 2/3] IIO: Add iio_chan modifier for True/Magnetic North HID usages |
| |
Hey Jonathan, > > I think we need the naming to explicitly mention north_magnetic instead > of just north. Whilst it is obvious what north means when you have north > true alongside it, it won't be so obvious if one just has the north > attribute > to see in a particular driver - if anything I'd have the true as the one > that was simply called north (as it might not be coming from a magnetometer > thought obviously that's the most common source) I'd also rather the enum > entries > were > IIO_MOD_NORTH_MAGN > IIO_MOD_NORTH_TRUE > IIO_MOD_NORTH_MAGN_TILT_COMP > IIO_MOD_NORTH_TRUE_TILT_COMP > > It is definitely feasible that they will not come from magnetometers - > a differential bearing is common on GPS units.
Makes sense to me. I will update the patches with your suggestions. Thanks.
| |