Messages in this thread | | | Subject | Re: [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only __initcall substitute | From | Joe Perches <> | Date | Mon, 02 Jun 2014 12:39:11 -0700 |
| |
On Mon, 2014-06-02 at 19:12 +0200, Fabian Frederick wrote: > This patch adds a link to init.h to find accurate initcall function > to replace obsolete __initcall
maybe s/accurate/appropriate/
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -4443,10 +4443,10 @@ sub process { > "$1 is obsolete, use k$3 instead\n" . $herecurr); > } > > -# check for __initcall(), use device_initcall() explicitly please > +# check for __initcall(), use device_initcall() explicitly or more accurate function please > if ($line =~ /^.\s*__initcall\s*\(/) { > WARN("USE_DEVICE_INITCALL", > - "please use device_initcall() instead of __initcall()\n" . $herecurr); > + "please use device_initcall() or more accurate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr); > }
| |