Messages in this thread | | | Date | Mon, 02 Jun 2014 11:35:16 -0700 | From | eric ernst <> | Subject | Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output |
| |
On 14-05-30 01:48 AM, Mika Westerberg wrote: > On Tue, May 27, 2014 at 12:26:44PM -0700, eric.ernst@linux.intel.com wrote: >> From: Eric Ernst <eric.ernst@linux.intel.com> >> >> For Baytrail, you should never set a GPIO set to direct_irq >> to output mode. When direct_irq_en is set for a GPIO, it is >> tied directly to an APIC internally, and making the pad output >> does not make any sense. Assert a WARN() in the event this happens. > Can't we just clear that flag when the GPIO is requested? Or is this > something which can't be done at this point? The IRQ setting for that register (the IRQ wiring via direct_irq_en) should be set statically on boot, and should not be changed, let alone allowing for multiple changes during runtime.
Eric
| |