lkml.org 
[lkml]   [2014]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output
On 14-05-30 01:48 AM, Mika Westerberg wrote:
> On Tue, May 27, 2014 at 12:26:44PM -0700, eric.ernst@linux.intel.com wrote:
>> From: Eric Ernst <eric.ernst@linux.intel.com>
>>
>> For Baytrail, you should never set a GPIO set to direct_irq
>> to output mode. When direct_irq_en is set for a GPIO, it is
>> tied directly to an APIC internally, and making the pad output
>> does not make any sense. Assert a WARN() in the event this happens.
> Can't we just clear that flag when the GPIO is requested? Or is this
> something which can't be done at this point?
The IRQ setting for that register (the IRQ wiring via direct_irq_en)
should be set statically on boot, and should not be changed, let alone
allowing for multiple changes during runtime.

Eric


\
 
 \ /
  Last update: 2014-06-02 21:21    [W:0.656 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site