lkml.org 
[lkml]   [2014]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] stmmac: Remove spin_lock call in stmmac_get_pauseparam()
From
From: Emil Goode <emilgoode@gmail.com>
Date: Mon, 2 Jun 2014 11:30:50 +0200

> The following patch removed unnecessary spin_lock/unlock calls
> in ethtool_ops callback functions. In the second and final version
> of the patch one spin_lock call was left behind.
>
> commit cab6715c3e8029e98b0b5d4056ceda007c0f6380
> Author: Yang Wei <Wei.Yang@windriver.com>
> Date: Sun May 25 09:53:44 2014 +0800
>
> net: driver: stmicro: Remove some useless the lock protection
>
> This introduced the following sparse warning:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
> context imbalance in 'stmmac_get_pauseparam' -
> different lock contexts for basic block
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

Good catch, applied, thanks Emil.


\
 
 \ /
  Last update: 2014-06-02 20:21    [W:0.035 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site