Messages in this thread | | | Subject | Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag | From | Joe Perches <> | Date | Mon, 02 Jun 2014 10:34:34 -0700 |
| |
On Mon, 2014-06-02 at 13:29 -0400, Steven Rostedt wrote: > On Mon, 02 Jun 2014 10:22:58 -0700 Joe Perches <joe@perches.com> wrote: > > > Paul Walmsley also noted the need for patch > > > submitters to know who the key reviewers are and suggested adding an > > > "R:" tag to the MAINTAINERS file to record this information on a > > > per-subsystem basis. [] > > Why not just mark the actual reviewers as maintainers? [] > If you have a person that regularly reviews a patch and wants to be > Cc'd on all of them, then why not add them to MAINTAINERS?
So we agree on that.
> > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > @@ -73,6 +73,8 @@ Descriptions of section entries: > > > L: Mailing list that is relevant to this area > > > W: Web-page with status/info > > > Q: Patchwork web based patch tracking system site > > > + R: Designated reviewer, who should be CCed on patches, > > > + format: FullName <address@domain> > > > T: SCM tree type and location. > > > Type is one of: git, hg, quilt, stgit, topgit > > > S: Status, one of the following: > > > > If this is actually done, I suggest putting this > > "R" entry description immediately after the "M" entry. [] > Or perhaps after L:
Either would be fine as long as the order is the same in the actual subsystem section entries that follow.
| |