lkml.org 
[lkml]   [2014]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] replace PAGECACHE_TAG_* definition with enumeration
On 06/01/2014 10:24 PM, Naoya Horiguchi wrote:
> -#define PAGECACHE_TAG_DIRTY 0
> -#define PAGECACHE_TAG_WRITEBACK 1
> -#define PAGECACHE_TAG_TOWRITE 2
> +enum {
> + PAGECACHE_TAG_DIRTY,
> + PAGECACHE_TAG_WRITEBACK,
> + PAGECACHE_TAG_TOWRITE,
> + __NR_PAGECACHE_TAGS,
> +};

Doesn't this end up exposing kernel-internal values out to a userspace
interface? Wouldn't that lock these values in to the ABI?


\
 
 \ /
  Last update: 2014-06-02 19:21    [W:0.091 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site