Messages in this thread | | | Date | Mon, 02 Jun 2014 09:12:25 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH 1/3] replace PAGECACHE_TAG_* definition with enumeration |
| |
On 06/01/2014 10:24 PM, Naoya Horiguchi wrote: > -#define PAGECACHE_TAG_DIRTY 0 > -#define PAGECACHE_TAG_WRITEBACK 1 > -#define PAGECACHE_TAG_TOWRITE 2 > +enum { > + PAGECACHE_TAG_DIRTY, > + PAGECACHE_TAG_WRITEBACK, > + PAGECACHE_TAG_TOWRITE, > + __NR_PAGECACHE_TAGS, > +};
Doesn't this end up exposing kernel-internal values out to a userspace interface? Wouldn't that lock these values in to the ABI?
| |