Messages in this thread | | | Date | Mon, 02 Jun 2014 08:16:08 -0700 | Subject | Re: [PATCH 2/2] clkdev: Export clk_register_clkdev | From | Darren Hart <> |
| |
On 6/2/14, 5:35, "Mark Brown" <broonie@kernel.org> wrote:
>On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart <dvhart@linux.intel.com> >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. >
That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second.
-- Darren Hart Open Source Technology Center darren.hart@intel.com Intel Corporation
| |