Messages in this thread | | | Date | Mon, 2 Jun 2014 23:01:55 +0900 | Subject | Re: [PATCH -mm 8/8] slab: reap dead memcg caches aggressively | From | Joonsoo Kim <> |
| |
2014-06-02 21:10 GMT+09:00 Vladimir Davydov <vdavydov@parallels.com>: > On Mon, Jun 02, 2014 at 01:41:55PM +0900, Joonsoo Kim wrote: >> According to my code reading, slabs_to_free() doesn't return number of >> free slabs. This bug is introduced by 0fa8103b. I think that it is >> better to fix it before applyting this patch. Otherwise, use n->free_objects >> instead of slabs_tofree() to achieve your purpose correctly. > > Hmm, I don't think slab_tofree() computes the number of free slabs > wrong. If we have N free objects, there may be > DIV_ROUND_UP(N,objs_per_slab) empty slabs at max, and that's exactly > what slab_tofree() does, no?
Oops... Sorry for wrong comment. You are right. Please ignore my comment. :)
BTW, we don't need DIV_ROUND_UP. I think that just N / objs_per_slab is sufficient to get number of empty slabs at max. Am I missing too?
Thanks.
| |