lkml.org 
[lkml]   [2014]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] rt2800usb:fix efuse detection
On Sun, Jun 01, 2014 at 11:06:11PM +0400, Sergei Shtylyov wrote:
> >+ rt2x00usb_vendor_request(rt2x00dev, USB_DEVICE_MODE,
> >+ USB_VENDOR_REQUEST_IN, 0, 0x11, &fwMode,
> >+ sizeof(fwMode), REGISTER_TIMEOUT_FIRMWARE);
> >+
> >+ if ((fwMode & 0x00000003) == 2)
>
> Operating directly on '__le32'? That doesn't look right.

rt2x00usb_register_read() helper can be used to do conversion. I also
dislike using 0x11 number instead of register name and prefer kernel
like variable names (i.e. fw_mode instead of fwMode).

Thanks
Stanislaw


\
 
 \ /
  Last update: 2014-06-02 15:41    [W:0.028 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site