Messages in this thread | | | Date | Mon, 2 Jun 2014 04:32:28 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH RFC] block: Eliminate first argument of submit_bio() |
| |
On Mon, Jun 02, 2014 at 11:44:07AM +0200, Bart Van Assche wrote: > The submit_bio() API is confusing. Merge functions like > raid5_mergeable_bvec() can only work correctly if bi_rw is set > before bio_add_page() has been called. submit_bio() modifies > bi_rw after bio_add_page() has been called. Hence remove the > first argument of submit_bio() and let the caller set bi_rw. > Note: some but not all submit_bio() callers have been fixed > such that bi_rw is set before bio_add_page() is called.
I like this a lot!
| |