Messages in this thread | | | Date | Mon, 2 Jun 2014 11:02:01 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR |
| |
On Mon, Jun 02, 2014 at 03:24:05PM +0530, Viresh Kumar wrote: > On 2 June 2014 15:21, Mark Brown <broonie@kernel.org> wrote:
> > When you say they check for a valid regulator how are they doing that? > > The stub will come into play if there isn't a dependency on REGULATOR.
> I meant they fail and quit if regulator_get() failed and so the first parameter > to regulator_set_voltage() is guaranteed to be valid.
No, think about what you're changing here. You're changing the stub - the stub has a regulator_get() which always succeeeds. [unhandled content-type:application/pgp-signature] | |