lkml.org 
[lkml]   [2014]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tty-next 10/22] char: synclink: Remove WARN_ON for bad port count
    Date
    tty_port_close_start() already validates the port counts and issues
    a diagnostic if validation fails.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/char/pcmcia/synclink_cs.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
    index a63970f..0ea9986 100644
    --- a/drivers/char/pcmcia/synclink_cs.c
    +++ b/drivers/char/pcmcia/synclink_cs.c
    @@ -2347,8 +2347,6 @@ static void mgslpc_close(struct tty_struct *tty, struct file * filp)
    printk("%s(%d):mgslpc_close(%s) entry, count=%d\n",
    __FILE__, __LINE__, info->device_name, port->count);

    - WARN_ON(!port->count);
    -
    if (tty_port_close_start(port, tty, filp) == 0)
    goto cleanup;

    --
    2.0.0


    \
     
     \ /
      Last update: 2014-06-16 16:01    [W:4.033 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site