Messages in this thread | | | Date | Fri, 9 May 2014 11:45:43 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/4] numa,x86: store maximum numa node distance |
| |
On Thu, May 08, 2014 at 01:23:28PM -0400, riel@redhat.com wrote: > From: Rik van Riel <riel@redhat.com> > > Store the maximum node distance, so the numa placement code can do > better placement on systems with complex numa topology. > > The function max_node_distance will return LOCAL_DISTANCE if the > system has simple NUMA topology, with only a single level of > remote distance. > > Signed-off-by: Rik van Riel <riel@redhat.com> > Tested-by: Chegu Vinod <chegu_vinod@hp.com> > --- > arch/x86/include/asm/topology.h | 3 +++ > arch/x86/mm/numa.c | 25 +++++++++++++++++++++++++ > include/linux/topology.h | 3 +++ > 3 files changed, 31 insertions(+) >
Why are you doing this in arch code? I would've expected some extra code to sched_init_numa() which is generic code that analyses the distance table and reconstructs the actual topology from it. [unhandled content-type:application/pgp-signature] | |