lkml.org 
[lkml]   [2014]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag
Date


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Thursday, May 8, 2014 4:45 PM
> To: Haiyang Zhang
> Cc: netdev@vger.kernel.org; KY Srinivasan; olaf@aepfle.de;
> jasowang@redhat.com; linux-kernel@vger.kernel.org; driverdev-
> devel@linuxdriverproject.org
> Subject: Re: [PATCH net-next,v2] Add support for netvsc build without
> CONFIG_SYSFS flag
>
> From: Haiyang Zhang <haiyangz@microsoft.com>
> Date: Thu, 8 May 2014 13:41:33 -0700
>
> > +static inline void netvsc_record_rx_queue(struct sk_buff *skb,
> > + struct hv_netvsc_packet *packet,
> > + struct net_device *ndev)
> > +{
> > +#ifdef CONFIG_SYSFS
> > + skb_record_rx_queue(skb, packet->channel->
> > + offermsg.offer.sub_channel_index %
> > + ndev->real_num_rx_queues);
> > +#endif
> > +}
>
> This is still fantastically gross, what is so unique about your driver that it needs
> hacks like this? No other driver to my knowledge does.
>
> Figure out what it is that makes your driver so unique, and try to make it
> conform to how other drivers handle these features without SYSFS ifdef'ery
> instead.
>

I looked around the other drivers, and the netif_set_real_num_rx_queues() function.
It's already switched to no-op without CONFIG_SYSFS flag. So I will rely on this, and
don't have to handle the flag in my code.

Thanks,
- Haiyang



\
 
 \ /
  Last update: 2014-05-08 23:41    [W:0.057 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site