Messages in this thread | | | Date | Sun, 4 May 2014 16:40:18 +0800 | From | Hongbo Zhang <> | Subject | Re: [PATCH v4 7/8] DMA: Freescale: use spin_lock_bh instead of spin_lock_irqsave |
| |
On 05/03/2014 12:51 AM, Vinod Koul wrote: > On Fri, Apr 18, 2014 at 04:17:50PM +0800, hongbo.zhang@freescale.com wrote: >> From: Hongbo Zhang <hongbo.zhang@freescale.com> >> >> The usage of spin_lock_irqsave() is a stronger locking mechanism than is >> required throughout the driver. The minimum locking required should be used >> instead. Interrupts will be turned off and context will be saved, it is >> unnecessary to use irqsave. >> >> This patch changes all instances of spin_lock_irqsave() to spin_lock_bh(). All >> manipulation of protected fields is done using tasklet context or weaker, which >> makes spin_lock_bh() the correct choice. >> > This doesnt apply, perhpas due to depends on 6/8 > So let's wait for the review result of 6/8.
| |