Messages in this thread | | | Date | Wed, 28 May 2014 10:15:43 +0200 | Subject | Re: [PATCH v2] pinctrl: Enable "power-source" to be extracted from DT files | From | Linus Walleij <> |
| |
On Tue, May 27, 2014 at 3:09 PM, Heiko Stübner <heiko@sntech.de> wrote: > Am Dienstag, 27. Mai 2014, 09:27:36 schrieb Ivan T. Ivanov: >> From: "Ivan T. Ivanov" <iivanov@mm-sol.com> >> >> Add "power-source" property to generic options used for DT parsing files. >> This enables drivers, which use generic pin configurations, to get the >> value passed to this property. > > I think the main problem here is, that pinconf-generic.h defines the power- > source as having a "custom format". With DT as a hardware description, > implementaton specific values do not work well - instead it should have a > regular unit-value. > > For the power-source I think volts could work well - as this is the main use- > case for pinctrl I know. The regulator-binding uses microvolts, maybe it would > be good use a similar unit. (...) > pcfg_1v8 { > power-source = <1800000>; > };
I don't think this is what it's meant for actually. In this case the thing would be modeled as a regulator rather than some pin control option I guess?
I think it's more like a selector, such as found on old amplifiers, input source A, B or C? So it's just some discrete number.
Then we don't know which voltage comes from power source A, B, C.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |