Messages in this thread | | | From | Vincent Guittot <> | Date | Tue, 27 May 2014 09:30:37 +0200 | Subject | Re: [PATCH v2 0/6] sched: expel confusing usage of the term "power" |
| |
Hi Nicolas,
There are still some use of "power" instead of "capacity" in the sched directory like SD_SHARE_CPUPOWER, ARCH_POWER or NONTASK_POWER. They should also be renamed in capacity as there are also used for capacity
Vincent
On 27 May 2014 00:19, Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > "Power" is a very bad term in the scheduler context. There are so many > meanings that can be attached to it. And with the upcoming "power > aware" scheduler work, confusion is sure to happen. > > The definition of "power" is typically the rate at which work is performed, > energy is converted or electric energy is transferred. The notion of > "compute capacity" is rather at odds with "power" to the point many > comments in the code have to make it explicit that "capacity" is the > actual intended meaning. > > So let's make it clear what we man by using "capacity" in place of "power" > directly in the code. That will make the introduction of actual "power > consumption" concepts much clearer later on. > > This is based on the latest tip tree to apply correctly on top of existing > scheduler changes already queued there. > > Changes from v1: > > - capa_factor and SCHED_CAPA_* changed to be spelled "capacity" in full > to save peterz some Chupacabra nightmares > > - some minor corrections in commit logs > > - rebased on latest tip tree > > > arch/arm/kernel/topology.c | 54 +++---- > include/linux/sched.h | 8 +- > kernel/sched/core.c | 87 ++++++----- > kernel/sched/fair.c | 323 ++++++++++++++++++++------------------- > kernel/sched/sched.h | 18 +-- > 5 files changed, 246 insertions(+), 244 deletions(-)
| |