Messages in this thread | | | Date | Mon, 26 May 2014 19:57:44 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 12/26] perf tools: Apply percent-limit to cumulative percentage |
| |
On Fri, May 23, 2014 at 07:04:09PM +0900, Namhyung Kim wrote:
SNIP
> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c > index 9f57991025a9..475d2f5c7e16 100644 > --- a/tools/perf/ui/stdio/hist.c > +++ b/tools/perf/ui/stdio/hist.c > @@ -461,12 +461,12 @@ print_entries: > > for (nd = rb_first(&hists->entries); nd; nd = rb_next(nd)) { > struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); > - float percent = h->stat.period * 100.0 / > - hists->stats.total_period; > + float percent; > > if (h->filtered) > continue; > > + percent = hist_entry__get_percent_limit(h); > if (percent < min_pcnt) > continue; > > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h > index ce37f3f8edd9..ad955fbd194f 100644 > --- a/tools/perf/util/hist.h > +++ b/tools/perf/util/hist.h > @@ -144,6 +144,7 @@ int hist_entry__sort_snprintf(struct hist_entry *he, char *bf, size_t size, > struct hists *hists); > void hist_entry__free(struct hist_entry *); > > + > void hists__output_resort(struct hists *hists); > void hists__collapse_resort(struct hists *hists, struct ui_progress *prog);
nit.. extra hunk ;-) I'll squash it
jirka
| |