Messages in this thread | | | Date | Mon, 26 May 2014 00:40:45 -0400 (EDT) | Subject | Re: [PATCH] wan: time_before() | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Sun, 25 May 2014 10:58:52 -0700
> On Sun, 2014-05-25 at 19:32 +0200, Manuel Schölling wrote: >> To be future-proof and for better readability the time comparisons are >> modified to use time_before() instead of plain, error-prone math. > > Sensible change, but it seems these should be > udelay(some_constant) instead of a a rather > variable time wait based on a system/config > defined jiffies.
Agreed, this code probably wants udelay(10) or something like that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |