Messages in this thread | | | Date | Fri, 23 May 2014 22:31:41 -0700 | Subject | Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings | From | Chaitanya Hazarey <> |
| |
Hey Dan,
Thanks for your patience, I have resubmitted via a new email. Hope that works.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 3:54 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declarations to fix the following warnings issued by checkpatch.pl: >> >> drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations >> drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations >> >> Signed-off-by: Chaitanya Hazarey <c@24.io> > > Still doesn't apply, I'm afraid. > >> --- >> drivers/staging/silicom/bypasslib/bypass.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c >> index a58251f..8e714a8 100644 >> --- a/drivers/staging/silicom/bypasslib/bypass.c >> +++ b/drivers/staging/silicom/bypasslib/bypass.c >> @@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data) >> static int is_dev_sd(int if_index) >> { >> int ret = 0; >> + >> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret); >> return ret >= 0 ? 1 : 0; >> } >> @@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index) >> static int is_bypass(int if_index) >> { >> int ret = 0; >> + >> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret); >> if (ret < 0) > > There was supposed to be a blank line between the call to > SET_BPLIB_INT_FN() and the return check and it got deleted for some > reason. > > regards, > dan carpetner > >
| |