Messages in this thread | | | Date | Fri, 23 May 2014 17:32:45 +0530 | Subject | Re: [PATCH 1/2] ASoC: max98090: Add master clock handling | From | Tushar Behera <> |
| |
On 23 May 2014 17:11, Mark Brown <broonie@kernel.org> wrote: > On Fri, May 23, 2014 at 05:06:27PM +0530, Tushar Behera wrote: >> On 23 May 2014 16:44, Mark Brown <broonie@kernel.org> wrote: > >> > Should be clk_prepare_enable() and similarly for the disable and you >> > should check the error codes but yes, that looks good. > >> I was planning to keep clk_prepare/clk_unprepare in probe/remove. > > Why - what purpose would it serve to leave the clock prepared but not > enabled?
I was getting some kernel slow path warning initially while preparing this code, but not able to reproduce that warning now.
-- Tushar Behera
| |