Messages in this thread | | | Date | Tue, 20 May 2014 10:24:47 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH V3 03/10] workqueue: async worker destruction |
| |
On Tue, May 20, 2014 at 05:46:29PM +0800, Lai Jiangshan wrote: > static void idle_worker_timeout(unsigned long __pool) > @@ -2289,6 +2298,10 @@ woke_up: > spin_unlock_irq(&pool->lock); > WARN_ON_ONCE(!list_empty(&worker->entry)); > worker->task->flags &= ~PF_WQ_WORKER; > + > + set_task_comm(worker->task, "kworker/dying");
Also, didn't I ask you to add comment for the above before?
> + worker_detach_from_pool(worker, pool); > + kfree(worker);
Thanks.
-- tejun
| |