lkml.org 
[lkml]   [2014]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test
Not for grep...

But if this is an issue I have no problem going back to the original.
We can spend a whole year just talking about codestyle.



On Tue, May 20, 2014 at 10:52 AM, David Laight <David.Laight@aculab.com> wrote:
> From: Alan Stern
> ...
>> > -static struct usb_request *
>> > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags)
>> > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep,
>> > + gfp_t gfp_flags)
>>
>> What's with the extreme indentation on the continuation line? The
>> style used here is for continuation lines to be indented by two stops
>> relative to the first line.
>
> Also why move the line break?
> The Linux kernel has both styles, and the original one (with the
> function name starting in column 1) makes it much easier to search
> to the definition.
>
> David
>
>
>



--
Ricardo Ribalda


\
 
 \ /
  Last update: 2014-05-20 11:21    [W:0.088 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site