lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] pwm: i.MX: Avoid sample FIFO overflow for i.MX PWM version2
Hi Lothar,

Thanks for your review.

On 05/19/2014 01:53 PM, Lothar Waßmann wrote:
> Hi,
>
> Liu Ying wrote:
> [...]
>> @@ -30,6 +32,7 @@
>> /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>>
>> #define MX3_PWMCR 0x00 /* PWM Control Register */
>> +#define MX3_PWMIR 0x08 /* PWM Interrupt Register */
>> #define MX3_PWMSAR 0x0C /* PWM Sample Register */
>> #define MX3_PWMPR 0x10 /* PWM Period Register */
>> #define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4)
>> @@ -38,7 +41,12 @@
>> #define MX3_PWMCR_DBGEN (1 << 22)
>> #define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16)
>> #define MX3_PWMCR_CLKSRC_IPG (1 << 16)
>> +#define MX3_PWMCR_SWR (1 << 3)
>> #define MX3_PWMCR_EN (1 << 0)
>> +#define MX3_PWMSR_ROV (1 << 4)
>> +#define MX3_PWMIR_RIE (1 << 1)
>> +
> You should decide whether to use tabs or spaces for indentation.
> And probably cleanup the indentation of the existing definitions to use
> all the same indentation style.

Ok, I will generate a separate patch to cleanup the indentation for
the existing register definitions of both i.MX PWMv1 and PWMv2.

>
>> @@ -128,6 +160,13 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
>> else
>> period_cycles = 0;
>>
>> + if (!enable || duty_cycles == 0)
>> + imx_pwm_software_reset_v2(chip);
>> + else if (readl(imx->mmio_base + MX3_PWMSAR))
>> + /* No rollover irq generated if duty peroid is zero. */
> typo: 'period'.

I will fix this.

>
>> @@ -135,27 +174,55 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
>> MX3_PWMCR_DOZEEN | MX3_PWMCR_WAITEN |
>> MX3_PWMCR_DBGEN | MX3_PWMCR_CLKSRC_IPG_HIGH;
>>
>> - if (test_bit(PWMF_ENABLED, &pwm->flags))
>> + if (enable)
>> cr |= MX3_PWMCR_EN;
>>
>> writel(cr, imx->mmio_base + MX3_PWMCR);
>>
>> + if (enable && duty_cycles)
>> + /* No rollover irq generated if duty peroid is zero. */
> dto.

I will fix this.

>
>
> Lothar Waßmann
>

--
Liu Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-05-19 09:21    [W:0.075 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site