lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars
On Mon, 19 May 2014 22:21:12 +0300 Dan Carpenter wrote:
> So, Jake, you're right, but if he redoes patch 2/6 then he has to redo
> the rest as well. The bad names were bad in the original code already,
> so normally we let people fix things up in follow on patches in that
> case.
>
> Is that ok with you?

Sure, that seems fine ... I only had fairly minor quibbles, the vast
majority of it is good stuff ...

Not sure it's useful (or even the right way to go about it), but, if it
is, Greg (or Jason or whoever) can add my:

Reviewed-by: Jake Edge <jake@lwn.net>

to the patch set ...

jake

--
Jake Edge - LWN - jake@lwn.net - http://lwn.net


\
 
 \ /
  Last update: 2014-05-20 05:41    [W:0.546 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site