lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: time to move fs/bio.c to block/ ?
On Mon, May 19, 2014 at 05:39:42PM +0100, Al Viro wrote:
> ACK on ioprio.c (BTW, looking at block... WTF is the story with that
> pile of blk-* in there? IOW, why blk-exec.c is better than exec.c,
> etc.?)
>
> As for fs/no-block.c... IMO that's a bad idea - it makes sense only
> if we take fs/block.c there as well, and that one wants fs/internal.h.

Right, we still have block_dev.c which is more VFS than block. Makes
sense to keep no-block.c then.

> Why do we need that ->llseek = noop_llseek there, while we are at it?
> Its ->open() always fails, so how is ->llseek() going to get looked at,
> let alone called?

Looks like a larger mechanical conversation of lseek instances..


\
 
 \ /
  Last update: 2014-05-20 02:21    [W:0.438 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site