Messages in this thread | | | Date | Tue, 20 May 2014 07:36:48 +0800 (SGT) | From | Julia Lawall <> | Subject | Re: [PATCH 2/13 v2] [SCSI] qla2xxx: make return of 0 explicit |
| |
On Mon, 19 May 2014, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 04:07:52PM +0000, Saurav Kashyap wrote: > > Hi Julia, > > > > Status is already set to 0 at the beginning of the function, I think > > we should just "return status" here to be consistent with the rest of > > the function. > > "return 0;" is more clear than "return status;". > > Consistency is great so long as it makes the code easier to read. Don't > lose track of the real goal.
If status were an informative word, there might be a reason for it. But integer typed functions almost always return their status, so there is no real information.
julia
| |