lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/13 v2] [SCSI] qla2xxx: make return of 0 explicit


On Mon, 19 May 2014, Dan Carpenter wrote:

> On Mon, May 19, 2014 at 04:07:52PM +0000, Saurav Kashyap wrote:
> > Hi Julia,
> >
> > Status is already set to 0 at the beginning of the function, I think
> > we should just "return status" here to be consistent with the rest of
> > the function.
>
> "return 0;" is more clear than "return status;".
>
> Consistency is great so long as it makes the code easier to read. Don't
> lose track of the real goal.

If status were an informative word, there might be a reason for it. But
integer typed functions almost always return their status, so there is no
real information.

julia


\
 
 \ /
  Last update: 2014-05-20 02:01    [W:1.468 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site