Messages in this thread | | | Subject | Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls | From | Joe Perches <> | Date | Mon, 19 May 2014 16:22:28 -0700 |
| |
On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick <fabf@skynet.be> wrote: > > Replace while blocksize;shift by fls -1 [] > fls() always makes my brain hurt. ilog() is nicer?
Maybe take an aspirin?
ilog2(n) is effectively fls(n) - 1 but n can be either u64 or u64 and ilog2 is compile-time optimized when n is constant.
blocksize is a non-const u32 here.
| |