lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] isdn: hisax: l3dss1.c: Fix for possible null pointer dereference
From
Hi

Ahh, yes. That's niecer..
I am sending a new patch. If it is as you intended, I do the same with
the l3ni1.c file.


Best regards
Rickard Strandqvist


2014-05-19 3:12 GMT+02:00 David Miller <davem@davemloft.net>:
> From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Date: Sat, 17 May 2014 19:18:21 +0200
>
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ...
>
>> @@ -2208,8 +2208,12 @@ static int l3dss1_cmd_global(struct PStack *st, isdn_ctrl *ic)
>> { free_invoke_id(st, id);
>> return (-2);
>> }
>> - pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; /* remember id */
>> - pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* and procedure */
>> +
>> + if (pc)
>> + {
>> + pc->prot.dss1.ll_id = ic->parm.dss1_io.ll_id; /* remember id */
>> + pc->prot.dss1.proc = ic->parm.dss1_io.proc; /* and procedure */
>> + }
>
> I think rather the intention was to put these pc-> assignments in the
> timeout > 0 code block.


\
 
 \ /
  Last update: 2014-05-19 23:41    [W:0.055 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site