Messages in this thread | | | Date | Mon, 19 May 2014 12:36:20 -0700 | Subject | Re: [PATCH] printk: Use symbolic defines for console loglevels | From | Kees Cook <> |
| |
On Mon, May 19, 2014 at 11:27 AM, Borislav Petkov <bp@alien8.de> wrote: > From: Borislav Petkov <bp@suse.de> > > ... instead of naked numbers. > > Stuff in sysrq.c used to set it to 8 which is supposed to mean above > default level so set it to DEBUG instead as we're terminating/killing > all tasks and we want to be verbose there. > > There should be no functionality change resulting from this patch. > > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: x86@kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.cz> > Cc: Jason Wessel <jason.wessel@windriver.com> > Cc: kgdb-bugreport@lists.sourceforge.net > Cc: Hedi Berriche <hedi@sgi.com> > Cc: Mike Travis <travis@sgi.com> > Cc: Dimitri Sivanich <sivanich@sgi.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Kees Cook <keescook@chromium.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Signed-off-by: Borislav Petkov <bp@suse.de>
Yes, please. Good clean-up. :)
Acked-by: Kees Cook <keescook@chromium.org>
-- Kees Cook Chrome OS Security
| |