lkml.org 
[lkml]   [2014]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/mce: Clear a useless global variable in mce.c
Date
-	atomic_inc(&mce_entry);
-

I have used this in the past (in conjunction with an external debugger) to
diagnose problems (not all cpus showing up in the machine check handler).

But I suppose these can also be diagnosed from the "Timeout synchronizing ..."
message from mce_timed_out() [though with a bit less precision ... we know
that some cpus didn't show up, but we don't have a count of how many did,
or how many are missing.

If we print the value of "mce_callin" somewhere in mce_timed_out() ...
then I think we'd have equivalent functionality (in fact better - because
we don't need the external debugger to peek at mce_entry).

-Tony


\
 
 \ /
  Last update: 2014-05-19 20:41    [W:0.054 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site