Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 11/20] perf report: Add -F option to specify output fields | Date | Mon, 19 May 2014 15:02:21 +0900 |
| |
On Fri, 16 May 2014 15:33:14 +0900, Namhyung Kim wrote: > On Thu, 15 May 2014 15:17:17 +0200, Jiri Olsa wrote: >> On Mon, May 12, 2014 at 03:28:44PM +0900, Namhyung Kim wrote: >> >> SNIP >> >>> + >>> +int setup_output_field(void) >>> +{ >>> + char *tmp, *tok, *str; >>> + int ret = 0; >>> + >>> + if (field_order == NULL) >>> + goto out; >>> + >>> + reset_dimensions(); >> >> Do we want to call this in setup_sorting as well? In case >> we mix the order of setup_output_field and setup_sorting >> in the future? > > Yeah, looks like a good idea.
Hmm.. I misunderstood your point. The thing is that the initialization step needs to be done in a specific order (due to their implicit dependency). So I change it to be called in one place, setup_sorting().
Thanks, Namhyung
| |