Messages in this thread | | | Date | Mon, 19 May 2014 10:59:04 -0400 | Subject | Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi | From | Benjamin Tissoires <> |
| |
On Wed, Apr 23, 2014 at 10:31 AM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > Currently, hid-rmi drives every Synaptics product, but the touchscreens > on the Windows tablets should be handled through hid-multitouch. > > Instead of providing a long list of PIDs, rely on the scan_report > capability to detect which should go to hid-multitouch, and which > should not go to hid-rmi. > > We introduce a generic HID_GROUP_HAVE_SPECIAL_DRIVER which can be reused > amoung other drivers if they want to have a catch rule but still > have multitouch devices handled through hid-multitouch. > > related bug: > https://bugzilla.kernel.org/show_bug.cgi?id=74241 > https://bugzilla.redhat.com/show_bug.cgi?id=1089583 > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > > Hi Jiri, > > well, this is the patch we are going to carry in Fedora as we are already > carrying hid-rmi. > Still, I am not 100% happy with it, especially the HID_GROUP_HAVE_SPECIAL_DRIVER > thing. > > I would also say we should re-think the way the scanning is called in > hid_add_device because I am starting using more and more the scanning capability > to decide if the device should be handled by generic, a special driver or simply > ignored. > > Anyway, this could be decided later. If you prefer me to use a hid-rmi specific > group like HID_GROUP_RMI instead of HID_GROUP_HAVE_SPECIAL_DRIVER, I can also > update the patch. >
Hi Jiri,
looks like this one did not attracted your eye yet. Can you ack / nack it? Without it, hid-rmi will break all the multitouch screens from Synaptics, which will be a little bit worrying :)
Cheers, Benjamin
| |