Messages in this thread | | | Date | Mon, 19 May 2014 12:52:52 +0200 | From | Tomasz Figa <> | Subject | Re: [PATCH] Fix for possible null pointer dereference in dma.c |
| |
Hi Rickard,
On 15.05.2014 23:57, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > sound/soc/samsung/dma.c | 10 ++++++---- > 1 fil ändrad, 6 tillägg(+), 4 borttagningar(-) > > diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c > index dc09b71..b1f6757 100644 > --- a/sound/soc/samsung/dma.c > +++ b/sound/soc/samsung/dma.c > @@ -115,17 +115,19 @@ static void dma_enqueue(struct snd_pcm_substream *substream) > static void audio_buffdone(void *data) > { > struct snd_pcm_substream *substream = data; > - struct runtime_data *prtd = substream->runtime->private_data; > + struct runtime_data *prtd = NULL; > > pr_debug("Entered %s\n", __func__); > > - if (prtd->state & ST_RUNNING) { > + if(substream) > + prtd = substream->runtime->private_data; > + > + if (prtd && prtd->state & ST_RUNNING) { > prtd->dma_pos += prtd->dma_period; > if (prtd->dma_pos >= prtd->dma_end) > prtd->dma_pos = prtd->dma_start; > > - if (substream) > - snd_pcm_period_elapsed(substream); > + snd_pcm_period_elapsed(substream); > > spin_lock(&prtd->lock); > if (!samsung_dma_has_circular()) { >
Can you find a path (or use case, if possible) on which any of affected pointers will be NULL?
Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |